add auth.conf.d resources#1087
Conversation
|
|
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Looks good but there seems to be some extra bits (see in-line comment).
manifests/init.pp
Outdated
| $sources.each |$key, $value| { | ||
| apt::source { $key: | ||
| * => $value, | ||
| } | ||
| } |
There was a problem hiding this comment.
This look like a duplicate of the above block.
There was a problem hiding this comment.
you're right, I removed the block
|
would it be possible to merge this PR? thank you |
|
Yes this seems useful! |
|
puppetlabs modules are really annoying! |
|
I have created Issue #1250 . thank you for merging |
|
Hey @aba-rechsteiner, Could you please take a look at the rspec failure. Also, it would be great if you could squash all the commit into one. |
|
aba-rechsteiner is not active anymore, you can contact me.
I could not use git squash, because there were already another commits between our commits, but I have branched main again, applied the patch of our all commits and commited as one commit and force pushed to branch "dev". Not it's one commit.
I hope I found it. If it will be OK, let me know please and I will squash the two commits again. Thank you. Regards, |
|
@shubhamshinde360 |
|
No worries @wolfaba. |
Maybe I found it now. There was no
After this last try I really have no idea anymore. Thank you. |
|
OK, |
|
Hi @wolfaba, This looks good to me. |
|
@shubhamshinde360 thank you |
8 participants
No description provided.