Fix version check in CentOS Stream 10 #1686
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use versioncmp to make sure 10 is considered newer than 7. Closes: puppetlabs#1673
kajinamit
requested review from
a team,
alexjfisher and
bastelfreak
as code owners
|
I could probably add acceptance tests with CentOS Stream 10 though I noticed even CentOS Stream 9 is not tested (and it seems CentOS was removed from test coverage since their migration to Stream concept ?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use versioncmp to make sure 10 is considered newer than 7.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
#1673
Checklist
puppet apply)