Fix version comparison for RedHat 10+#1696
Open
Garamotte wants to merge 1 commit intopuppetlabs:mainfrom
Open
Conversation
Garamotte
requested review from
a team,
alexjfisher and
bastelfreak
as code owners
|
|
|
jfyi: I proposed the same fix earlier though this repository is almost abandoned and we've seen no interest from maintainers for merging it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The version check for RedHat is wrong, using
<instead ofversioncmp.This causes RedHat 10 to be considered below RedHat 7.
Checklist
puppet apply)