You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description of the change
Adds a variant of prop using VTA (visible type application) which was added in Purescript 0.15.10. Motivation is mainly to save some characters:
I chose to also name it prop and put it in a new module (as it seems very unlikely that both variants are used in the same project), but also happy to change to other alternatives, like naming it prop' and putting it in Data.Lens.Record, or simply replacing the current prop with the VTA-enabled prop (would be a breaking change).
Checklist:
Added the change to the changelog's "Unreleased" section with a link to this PR and your username
Linked any existing issues or proposals that this pull request should close
Updated or added relevant documentation in the README and/or documentation directory
Adding VTAs to the ecosystem is something I was planning to do in the 0.16.0 ecosystem update. And before that happens, we need to specify some guidelines for how to do this, so that whatever design we come up with is consistent across the ecosystem rather than ad-hoc designs that differ across libraries.
If you're interested in contributing to this effort, please type up some initial guidelines on Discourse.
prop is by far the most frequently referenced function in our codebase. This is an opportunity to pick a shorter name for the combinator. How about on?
Does your codebase entail a library or application. If the latter, there's nothing stopping you from defining your own prelude with its custom imports to suit your naming preferences.
It's an application, and indeed we do have a P4 for exactly that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a variant of
propusing VTA (visible type application) which was added in Purescript 0.15.10. Motivation is mainly to save some characters:vs
I chose to also name it
propand put it in a new module (as it seems very unlikely that both variants are used in the same project), but also happy to change to other alternatives, like naming itprop'and putting it inData.Lens.Record, or simply replacing the currentpropwith the VTA-enabledprop(would be a breaking change).Checklist: