-
Notifications
You must be signed in to change notification settings - Fork 33
OffscreenCanvas support and Blob creation #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
UnrelatedString
wants to merge
14
commits into
purescript-web:master
Choose a base branch
from
UnrelatedString:offscreen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluding as I just realized uhh being able to actually obtain offscreen canvases
…YNC in normal canvases. we love web apis wow
…t this. this literally returns undefined. aaaaaaaaaaaa i hate js so muchhhhhhh
… having this solved...
(I also haven't actually tested any of this at all...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a new module
Graphics.Canvas.Offscreen
containing bindings to theOffscreenCanvas
interface, and adds bindings forHTMLCanvasElement.toBlob
.Semi-solves #75 -- doesn't directly allow creation of canvas elements, but gives a better purpose-built API for @thanacles' use case.
One thing that I haven't added because it somewhat worries me to add is
transferControlToOffscreen
. Given that it errors if the canvas has a context already, and getting a context on the canvas errors if it's been transferred, I'm unsure if simply allowing the JS to error withinEffect
is appropriate. Maybe it should just be prefixedunsafe
?I have also not added
transferToImageBitmap
, because there's no existing bindings for theImageBitmap
type and adding them seems like another far more involved PR's worth of work in and of itself.I'm also worried about the
aff
7.1.0
dependency imposed byaff-promise
, mostly because I don't actually know how package sets work. I tried to usejs-promise-aff
, but Bower couldn't find it. I imagine it wouldn't be too difficult to remove the dependency entirely, but I'm in way over my head with anything async.Checklist: