Fix fetchMultipartMessages query params #49
Conversation
As the `getOptionalFields` method didn't return anything the api request didn't have any passed query params.
Was incorrectly using the count of the initial messages instead of the expected sliced messages. Originally passed as the query params where not being included in the request limiting the messages.
Cover both newer & older directions
|
Anything I can do to get TravisCI running? Tests pass locally for me. Seems that it doesn't run with external forks. |
|
@jamesfairhurst: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
|
@jamesfairhurst: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jamesfairhurst: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What?
Fixed
fetchMultipartMessageswith query params.Why?
As the
getOptionalFieldsmethod didn't return anything the api request didn't have any passed query params.