Fix: Extended Event custom icon rendering and sample update - #53
Merged
Conversation
pushpalroy
marked this pull request as ready for review
August 10, 2025 18:08
There was a problem hiding this comment.
Pull Request Overview
This PR fixes custom icon rendering issues in JetLimeExtendedEvent and updates the sample app to properly showcase all event point types. The changes address bugs where custom icons weren't displaying their background/fill correctly and where tinting wasn't applied properly.
- Fixed custom icon background and tinting in
JetLimeExtendedEvent - Updated sample to demonstrate all event point types including custom icons
- Improved icon visibility across different themes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| jetlime/src/commonMain/kotlin/com/pushpal/jetlime/JetLimeExtendedEvent.kt | Fixes custom icon rendering by ensuring background circles are drawn and applying proper tinting |
| sample/composeApp/src/commonMain/kotlin/timelines/event/EventContent.kt | Updates sample to include custom event point types and adds @composable annotation |
| sample/composeApp/src/commonMain/kotlin/timelines/ExtendedVerticalTimeLine.kt | Adds styling configuration to improve custom icon visibility |
| README.md | Updates version badges for Compose and Kotlin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issues (#47) with the rendering of custom icons in
JetLimeExtendedEventand updates theExtendedVerticalTimeLinesample to correctly showcase all event point types.Bug Fixes in
JetLimeExtendedEvent:pointColor) and the fill (defined bypointFillColorandfillPercent) are drawn correctly behind custom icons. Previously, custom icons would appear without their intended background/fill.tintto custom icons. Thetintspecified inEventPointType.custom(icon = ..., tint = ...)is now properly applied.radius * fillPercentfor improved clarity and robustness.Sample Updates (
ExtendedVerticalTimeLine&EventContent.kt):decidePointType()function in the sample'sEventContent.kthas been updated to includeEventPointType.custom, allowing theExtendedVerticalTimeLineto demonstrateDefault,filled, andcustompoint types.painterResource) was not visible in the sample, particularly in dark mode. This was due to the icon tint (MaterialTheme.colorScheme.onPrimaryContainer) not contrasting with the event point's background color (Color.White). The tint for the sample's custom icon has been changed toMaterialTheme.colorScheme.primaryto ensure visibility across themes.decidePointType: ThedecidePointType()function is now correctly marked as@Composableas it utilizespainterResource.These changes ensure that
JetLimeExtendedEventrenders points consistently withJetLimeEventand that the sample accurately reflects the library's capabilities.Screenshot of the fixed version: