Fix plotting in plot_singlediode.py gallery page#1895
Merged
kandersolar merged 4 commits intopvlib:mainfrom Oct 23, 2023
Merged
Fix plotting in plot_singlediode.py gallery page#1895kandersolar merged 4 commits intopvlib:mainfrom
kandersolar merged 4 commits intopvlib:mainfrom
Conversation
fixed plot annotations by moving plt.show() further down
kandersolar
reviewed
Oct 23, 2023
docs/sphinx/source/whatsnew.rst
Outdated
| Contributors | ||
| ~~~~~~~~~~~~ | ||
| * Will Hobbs (:ghuser:`williamhobbs`) | ||
|
|
Member
There was a problem hiding this comment.
Can you move these changes to v0.10.3.rst? whatsnew.rst is just an index for the files for each release; it doesn't house any actual content itself.
Also, I think this item should be under Documentation instead of Bug fixes.
Contributor
Author
There was a problem hiding this comment.
Oops. I updated v0.10.3.rst.
Basic GitHub question: how do I roll back changes to whatsnew.rst?
Member
There was a problem hiding this comment.
Looks like you're using GitHub's web interface to make commits? I don't use it myself but I assume it's possible to edit that file and create a new commit that removes those lines, in much the same way it created a commit to add them.
Another option is to suggest a change to delete those lines and then accept it here in the PR itself.
The most general method is to use a local git client and your own text editor, but that's a bit more involved than clicking a few buttons here on github :)
Contributor
Author
There was a problem hiding this comment.
Thanks! Yeah, I'm using the web interface. I need to get familiar with git...
williamhobbs
commented
Oct 23, 2023
Undoing changes to whatsnew.rst
kandersolar
changed the title
kandersolar
approved these changes
Oct 23, 2023
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
LGTM, thanks @williamhobbs!
kandersolar
added a commit
that referenced
this pull request
Nov 29, 2023
* Remove various repeated words in documentation (#1872) * Remove repeated words * Update pvlib/ivtools/sdm.py Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * fix invalid escape sequence '\c' (#1879) * fix invalid escape sequence '\c' pvlib/iam.py:843: DeprecationWarning: invalid escape sequence '\c' Occurence is actually in line 854: `IAM = 1 - (1 - \cos(aoi))^5` * Add to list of contributors * Replace use of deprecated `pkg_resources` (#1881) (#1882) * Update infinite_sheds.py to add shaded fraction to returned variables in infinite_sheds.get_irradiance and infinite_sheds.get_irradiance_poa (#1871) * Update infinite_sheds.py Added shaded fraction to returned variables. * Update v0.10.3.rst * Update test_infinite_sheds.py added tests for shaded fraction * Update test_infinite_sheds.py Corrected the shaded fraction tests in the haydavies portion. * Update pvlib/bifacial/infinite_sheds.py Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Update infinite_sheds.py * Update infinite_sheds.py * Update infinite_sheds.py fixed indentation issues --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Continuous version of the Perez transposition model implementation (#1876) * Definitely not ready for review! * Big step forward. * Add entry in docs. * A working model but just one test sofar. * Add new model as option in get_sky_diffuse. Docstring edits pending. * Completed doc strings. Also a bit of fine-tuning code. * Updated whatsnew. * Bugfix, formatting fix, and add all tests. * Test warning plus some other small changes. * Make flake happy. * Update pvlib/irradiance.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Address comments. * Add contributor code comments. * Update pvlib/irradiance.py Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Adapt to reviewer preferences. * Adapt to flake preferences. * Remove model pseudo-option. * Flake --------- Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Fix spurious test error with pandas 2.1 (#1891) pandas-dev/pandas#55014 * Fix plotting in plot_singlediode.py gallery page (#1895) * Update plot_singlediode.py fixed plot annotations by moving plt.show() further down * Update whatsnew.rst * Update v0.10.3.rst * Update docs/sphinx/source/whatsnew.rst Undoing changes to whatsnew.rst * Address pandas FutureWarnings in test suite (#1900) * Cahnged expected reference in test_detect_clearskY_window to 1 from True to avoid Futurewarning * Change reference to etr in ibird function to avoid FutureWarning * In test_modelchain, update all instances when referring to series by position to using iloc to get rid of FutureWarning * Update to iloc method for referencing by position in test_irradiance to get rid of FutureWarning * In test_singlediode change applymap to map to get rid of FutureWarning * Test_srml update to select using iloc to get rid of FutureWarning * Substitute changing to float64 dtype using map with base functionality that's accessible across Pandas versions * Added username to Contributors * Update line break in test_clearsky to adhere to line length limit * add comparisons to other tools * Apply suggestions from code review Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * revision re: other open-source projects * bibtex tweaks * clarify pvlib matlab comparison --------- Co-authored-by: Miroslav Šedivý <6774676+eumiro@users.noreply.github.com> Co-authored-by: Arjan Keeman <akeeman@users.noreply.github.com> Co-authored-by: Miguel Sánchez de León Peque <peque@neosit.es> Co-authored-by: Will Hobbs <45701090+williamhobbs@users.noreply.github.com> Co-authored-by: Anton Driesse <anton.driesse@pvperformancelabs.com> Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> Co-authored-by: matsuobasho <rkoulikov@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the plot annotations in the IV curve gallery example by moving plt.show() further down.
[ ] Tests added[ ] Updates entries in [(https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/reference) for API changes.docs/sphinx/source/reference]docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.