Add NASA POWER to iotools #2500
Conversation
|
@AdamRJensen could you give some first feedback on this? Also, should there also be a |
I suggest just adding a |
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
| community: str | ||
| Can be one of the following depending on which parameters are of | ||
| interest. The default is ``'re'``. Note that in many cases this choice |
There was a problem hiding this comment.
| community: str | |
| Can be one of the following depending on which parameters are of | |
| interest. The default is ``'re'``. Note that in many cases this choice | |
| community: str, default 're' | |
| Can be one of the following depending on which parameters are of | |
| interest. Note that in many cases this choice |
| map_variables: bool, optional | ||
| When true, renames columns of the Dataframe to pvlib variable names | ||
| where applicable. See variable :const:`VARIABLE_MAP`. | ||
| The default is `True`. |
There was a problem hiding this comment.
| map_variables: bool, optional | |
| When true, renames columns of the Dataframe to pvlib variable names | |
| where applicable. See variable :const:`VARIABLE_MAP`. | |
| The default is `True`. | |
| map_variables: bool, default True | |
| When true, renames columns of the Dataframe to pvlib variable names | |
| where applicable. See variable :const:`VARIABLE_MAP`. |
|
|
||
| def test_get_nasa_power(data_index, ghi_series): |
There was a problem hiding this comment.
| def test_get_nasa_power(data_index, ghi_series): | |
| @pytest.mark.remote_data | |
| @pytest.mark.flaky(reruns=RERUNS, reruns_delay=RERUNS_DELAY) | |
| def test_get_nasa_power(data_index, ghi_series): |
All test functions that access internet APIs should have these two decorators :)
And add from tests.conftest import RERUNS, RERUNS_DELAY at the top of the file.
| * ``ALLSKY_SFC_SW_DIFF``: Diffuse Horizontal Irradiance (DHI) [Wm⁻²] | ||
| * ``ALLSKY_SFC_SW_DNI``: Direct Normal Irradiance (DNI) [Wm⁻²] | ||
| * ``T2M``: Air temperature at 2 m [C] | ||
| * ``WS10M``: Wind speed at 10 m [m/s] |
There was a problem hiding this comment.
I suggest using pvlib names here and in the default parameter list. As a user, I don't want to have to mentally translate ALLSKY_SFC_SW_DWN into ghi when reading these docs.
There was a problem hiding this comment.
@kandersolar to clarify: are you suggesting that the pvlib function accept values like 'ghi' in place of 'ALLSKY_SFC_SW_DIFF'?
There was a problem hiding this comment.
The pvlib function currently accepts both of those and I am not suggesting changing that. The suggestion is for the default values to use pvlib names instead of NASA POWER names, to (IMHO) make the docstring a little clearer.
| hourly_data = data['properties']['parameter'] | ||
| df = pd.DataFrame(hourly_data) | ||
| df.index = pd.to_datetime(df.index, format='%Y%m%d%H').tz_localize('UTC') | ||
| df = df.replace(-999, np.nan) |
There was a problem hiding this comment.
perhaps worth using meta['fill_value'] instead of hardcoding -999, in case they change it someday?
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR adds a function to get irradiance and weather data from NASA POWER. read_the_docs_link