Update _writer.py - Invalid Link Fix #2448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passes an IndirectObject for the target page instead of an integer. passing an integer creates an invalid link. resolves #2443 Issue
|
Could you please add a corresponding test case as well which shows the previous issue and demonstrates that your fix does indeed solve this? |
rsinger417
added a commit
to rsinger417/pypdf
that referenced
this pull request
Feb 8, 2024
passes an IndirectObject for the target page instead of an integer. passing an integer creates an invalid link. resolves py-pdf#2443 Issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passes an IndirectObject for the target page instead of an integer. passing an integer creates an invalid link.
resolves #2443 Issue