Skip to content

Conversation

Phinart98
Copy link
Collaborator

closes #19

  • Fix mobile menu covering logo by positioning menu below navigation bar instead of overlaying it

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a bit of cleanup before I can review it @Phinart98 but thank you so so much for the work you've put into this so far!!

@Phinart98 Phinart98 force-pushed the #19-fix-mobile-logo-display branch from a53b915 to 2ab1db4 Compare August 22, 2025 19:53
@lwasser
Copy link
Member

lwasser commented Aug 22, 2025

nice @Phinart98 !! i'll try to have a look at this again before i sign off today!

@Phinart98
Copy link
Collaborator Author

@melissawm , please review this one too. I think @lwasser did not have enough time to review it before going off last week. I believe I fixed the issues by applying the force push.

@melissawm
Copy link
Collaborator

melissawm commented Aug 26, 2025

Looks good to me now!

Screenshot 2025-08-26 at 5 43 08 PM

Merging as discussed, thanks @Phinart98 !

@melissawm melissawm merged commit d3bc422 into pyOpenSci:main Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: hamburger menu drop down / logo missing in mobile
3 participants