Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: use graphql to consolidate api calls #267

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Mar 5, 2025

Next steps

  • Run on all packages
  • Consider a small reorg; put all gh metrics in the github module
  • 🐛 contrib count isn't correct. (this is because this endpoint isn't available via graphQL. other options are mentionable and collaborators but those are different metrics.
  • Move get_gh_metrics to github module

@lwasser lwasser marked this pull request as draft March 6, 2025 00:00
Fix: full run

fix: bugs in run
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 15.90909% with 37 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (302d8b5) to head (14d1b6c).

Files with missing lines Patch % Lines
src/pyosmeta/github_api.py 17.64% 28 Missing ⚠️
src/pyosmeta/parse_issues.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   76.27%   78.26%   +1.98%     
==========================================
  Files          10       10              
  Lines         725      713      -12     
  Branches       92       92              
==========================================
+ Hits          553      558       +5     
+ Misses        162      145      -17     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lwasser
Copy link
Member Author

lwasser commented Mar 6, 2025

bummer. if we move to graphql we can't get a contributor count. We could consider a separate workflow just for that metric in the future.

repo_endpoints, accepted_reviews
)

# BUG : contrib count isn't correct - great tables has some and is returning 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a bug, the endpoint isn't available via graphql.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR to use rest just for that metric. it reduces the api calls by one per package vs two now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant