-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: use graphql to consolidate api calls #267
base: main
Are you sure you want to change the base?
Conversation
Fix: full run fix: bugs in run
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 76.27% 78.26% +1.98%
==========================================
Files 10 10
Lines 725 713 -12
Branches 92 92
==========================================
+ Hits 553 558 +5
+ Misses 162 145 -17
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bummer. if we move to graphql we can't get a contributor count. We could consider a separate workflow just for that metric in the future. |
src/pyosmeta/cli/process_reviews.py
Outdated
repo_endpoints, accepted_reviews | ||
) | ||
|
||
# BUG : contrib count isn't correct - great tables has some and is returning 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a bug, the endpoint isn't available via graphql.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR to use rest just for that metric. it reduces the api calls by one per package vs two now.
fix: cleanup commented methods
Next steps