Remove "License :: ..." classifiers from pyproject.toml examples #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucodery
reviewed
Jul 23, 2025
There was a problem hiding this comment.
Thanks for this PR! I really like your new descriptions of why to use classifiers, even without licenses.
The license metadata field used to be overloaded to mean two different things at the same time, depending on the type of value. Those meanings have been divided between two distinct fields and we should be explicit about that.
Update use of "license = ..." key to use short reference. See pyOpenSci#557 for discussion
- aim to be clear that pyproject.toml license entry is a "short code" or reference to the choice of license - add note on and link to SPDX expressions for precision - add sentence on license-files key for completeness
tomalrussell
force-pushed
the
fix/license-classifiers
branch
from
af0549f to
3e57a98
Compare
ucodery
approved these changes
Aug 1, 2025
ucodery
reviewed
Aug 1, 2025
Co-authored-by: Jeremiah Paige <[email protected]>
Co-authored-by: Jeremiah Paige <[email protected]>
ucodery
approved these changes
Aug 4, 2025
|
@all-contributors please add @tomalrussell for code and doc |
|
I've put up a pull request to add @tomalrussell! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update recommended use of "license = ..." key to use the short reference code for common licenses, rather than the legacy
{ file = "LICENSE" }specification.See #557 for discussion