feat(pipeline): add preload option to base Pipeline class to force preload audio in memory.
#1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow preloading of the waveform in pipeline call
hbredin
changed the title
preload option to base Pipeline class to force preload audio in memory.
hbredin
previously approved these changes
Nov 8, 2025
Member
hbredin
left a comment
hbredin
left a comment
There was a problem hiding this comment.
- Renamed flag to (shorter)
preload - Added a docstring that has been missing from the beginning
- Rewrote (slightly) the logic
@antoinelaurent can you please check that I did not break anything with the latter point?
hbredin
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for waveform preloading in pipeline call.