Skip to content

Appease MSVC Warning C4866: Cast pointers to handles explicitly before indexing #5955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 1 commit into from
Jan 10, 2026
+5 −4
Merged

Appease MSVC Warning C4866: Cast pointers to handles explicitly before indexing #5955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions include/pybind11/pybind11.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,10 +1081,11 @@ class cpp_function : public function {
dict kwargs;
for (size_t i = 0; i < used_kwargs.size(); ++i) {
if (!used_kwargs[i]) {
// Fetch value before indexing into kwargs to ensure well-defined
// evaluation order (MSVC C4866).
PyObject *const arg_in_arr = args_in_arr[n_args_in + i];
kwargs[PyTuple_GET_ITEM(kwnames_in, i)] = arg_in_arr;
// Cast values into handles before indexing into kwargs to ensure
// well-defined evaluation order (MSVC C4866).
handle arg_in_arr = args_in_arr[n_args_in + i],
kwname = PyTuple_GET_ITEM(kwnames_in, i);
kwargs[kwname] = arg_in_arr;
}
}
call.args.push_back(kwargs);
Expand Down
Loading