Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pybind11_protobuf when passing Fingerprints. #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use pybind11_protobuf when passing Fingerprints. #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pybind11_protobuf/proto_caster_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,24 @@ struct proto_caster_load_impl {

// load converts from Python -> C++
bool load(pybind11::handle src, bool convert) {
LOG(ERROR) << 1;
// When given a none, treat it as a nullptr.
if (src.is_none()) {
value = nullptr;
return true;
}
LOG(ERROR) << 1;
// NOTE: We might need to know whether the proto has extensions that
// are python-only.

// Attempt to use the PyProto_API to get an underlying C++ message pointer
// from the object.
const ::google::protobuf::Message *message =
pybind11_protobuf::PyProtoGetCppMessagePointer(src);
LOG(ERROR) << 1;
if (message && message->GetReflection() ==
ProtoType::default_instance().GetReflection()) {
LOG(ERROR) << 1;
// If the capability were available, then we could probe PyProto_API and
// allow c++ mutability based on the python reference count.
value = static_cast<const ProtoType *>(message);
Expand All @@ -62,13 +66,17 @@ struct proto_caster_load_impl {

// The incoming object is not a compatible fast_cpp_proto, so check whether
// it is otherwise compatible, then serialize it and deserialize into a
LOG(ERROR) << 1;
// native C++ proto type.
if (!pybind11_protobuf::PyProtoIsCompatible(src,
ProtoType::GetDescriptor())) {
LOG(ERROR) << 1;
return false;
}
LOG(ERROR) << 1;
owned = std::unique_ptr<ProtoType>(new ProtoType());
value = owned.get();
LOG(ERROR) << 1;
return pybind11_protobuf::PyProtoCopyToCProto(src, owned.get());
}

Expand Down