pbio/drv/bluetooth_stm32_cc2640: Use loops to set params. #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holy object code, Batman! Nice find! |
When inspecting the map.elf, the init_task was well over 4K. Since much of it is repetition with different parameters, we can vastly reduce the number of different entry and yield points by looping over a list of parameters instead. This reduces the firmware size by nearly 2K, which is helpful since we are running short on Technic Hub. Almost everything is still set in the same order. Only the bond manager configuration is reordered slightly so we can use a single loop.
laurensvalk
force-pushed
the
btrework
branch
from
e1aa338 to
0f065bb
Compare
dlech
reviewed
Sep 18, 2025
| } | ||
|
|
||
| typedef struct { | ||
| const uint8_t *uuid128; // Null means uuid16 is used. |
There was a problem hiding this comment.
Suggested change
| const uint8_t *uuid128; // Null means uuid16 is used. | |
| const uint8_t *uuid128; // NULL means uuid16 is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an independent spin-off from other Bluetooth progress. This has not yet been tested.
When inspecting the map.elf, the init_task was well over 4K. Since much of it is repetition with different parameters, we can vastly reduce the number of different entry and yield points by looping over a list of parameters instead.
This reduces the firmware size by nearly 2K, which is helpful since we are running out of space on Technic Hub. 🎉
Almost everything is still set in the same order so should work the same if we didn't copy things incorrectly. Only the bond manager configuration is reordered slightly so we can use a single loop.