Skip to content

Conversation

pepijndevos
Copy link
Contributor

This allows you to pass a script that imports a binary .mpy module and combine it as-is without compilation.

I imagine this could also be useful to save some compile time if you want to upload some larger dependency, but my main use for this is to build binary extensions. Like so https://docs.micropython.org/en/latest/develop/natmod.html

Copy link
Member

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I made a few comments with suggested changes and we should also add a changelog entry for this.

@pepijndevos
Copy link
Contributor Author

Ok I've update the code to not search the system path and added an abi version check.

Copy link
Member

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. If it is still working after all of these changes, I think it is ready to merge.

@pepijndevos
Copy link
Contributor Author

Tests pass and I can still upload code with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants