-
Notifications
You must be signed in to change notification settings - Fork 21
look for already compiled .mpy modules #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. I made a few comments with suggested changes and we should also add a changelog entry for this.
Co-authored-by: David Lechner <[email protected]>
Ok I've update the code to not search the system path and added an abi version check. |
Co-authored-by: David Lechner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. If it is still working after all of these changes, I think it is ready to merge.
Tests pass and I can still upload code with it :) |
This allows you to pass a script that imports a binary .mpy module and combine it as-is without compilation.
I imagine this could also be useful to save some compile time if you want to upload some larger dependency, but my main use for this is to build binary extensions. Like so https://docs.micropython.org/en/latest/develop/natmod.html