Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #12132 -- implement ssh public key fingerprints #12673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes #12132 -- implement ssh public key fingerprints #12673

wants to merge 1 commit into from

Conversation

alex
Copy link
Member

@alex alex commented Mar 24, 2025

No description provided.

@alex
Copy link
Member Author

alex commented Mar 24, 2025

(This was mostly developed by claude-code, but eventually I got bored of baby sitting it and so I just cleaned it up myself)

@alex alex force-pushed the ssh-key-fingerprint branch from ad0e0a0 to cd7538a Compare March 24, 2025 17:18
@alex alex force-pushed the ssh-key-fingerprint branch from cd7538a to 0007fb5 Compare March 24, 2025 17:24
@alex
Copy link
Member Author

alex commented Mar 24, 2025

Two choices I made here:

  1. I do not include the algorithm name as a prefix
  2. For hex, I do not separate the characters by :

My theory was that adding those by a caller is easy-ish, but undoing them is annoying. But I'm not wedded to this.

@alex alex mentioned this pull request Mar 24, 2025
Open
@alex
Copy link
Member Author

alex commented Mar 28, 2025

an alternative here would be to just compute the hash, no serialization at all.

@alex alex requested a review from Copilot April 4, 2025 12:28
Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • CHANGELOG.rst: Language not supported
  • docs/hazmat/primitives/asymmetric/serialization.rst: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alex