Conversation
Classify workflows by layer, purpose, and integration. Enforce that every discovered Dag has at least one tag.
ttw225
reviewed
Jul 24, 2026
ttw225
left a comment
ttw225
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall — the layer / purpose / integration split is clean and easy
to follow.
The one thing I'd like to align before merge is the notification tag: five of
the app Dags post to Discord, but only two carry it (details in the inline
comment on finance_bot). Since it's your own taxonomy, unifying those five
keeps the purpose axis consistent — happy to defer if you meant domain to take
priority there.
Optional: if the layer values are meant to be a fixed set (app / ods /
maintenance), a short note in CLAUDE.md would help the next person pick the
right one.
Thanks for putting this together 🙏
Add the `gemini` integration tag to the user_profile Dag, the only Dag calling an external AI service (gemini-2.0-flash) and previously the only one without an integration tag. Deliberately omits `bigquery`: nearly every Dag touches it, so it carries no filtering value on the integration axis.
Add the `notification` purpose tag to DISCORD_FINANCE_REMINDER, proposal_count and registration_statistics, which post to Discord but previously carried only their domain tag. Filtering the purpose axis for `notification` now returns all five Dags that notify people instead of two. Existing domain tags are kept.
Record that every Dag carries exactly one layer tag from the closed set `app` / `ods` / `maintenance`, so the next person adding a Dag knows which layer it belongs to. Domain and integration axes stay open-ended — held by convention and review rather than a whitelist, which would rot as new integrations arrive. `bigquery` is deliberately untagged: nearly every Dag touches it.
The module docstring only mentioned the import/parse smoke test, but the module also asserts Dag ID uniqueness and that every Dag carries tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classify workflows by layer, purpose, and integration. Enforce that every discovered Dag has at least one tag.
Types of changes
Description
Checklist
make lintandmake testlocally to ensure all linter checks and testing passSteps to Test This Pull Request
Expected behavior
Related Issue
Additional context