internal: add a marker for the first span event for each exception #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to differentiate in the backend if this is the span an exception originated inside of vs. subsequent spans it tears through as it goes up the stack
Deploying logfire-docs with
|
| Latest commit: |
f374dd1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19c6165c.logfire-docs.pages.dev |
| Branch Preview URL: | https://dedupe-exceptions.logfire-docs.pages.dev |
adriangb
commented
Feb 25, 2025
| # our backend can replicate the behavior of exceptions as OTEL logs, see | ||
| # https://github.com/open-telemetry/opentelemetry-specification/pull/4430#issue-2876146448 | ||
| # and linked issues. | ||
| attributes['logfire.exception_first_recorded'] = True |
There was a problem hiding this comment.
@alexmojaki the idea is that we only explode exception span events if this attribute is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to differentiate in the backend if this is the span an exception originated inside of vs. subsequent spans it tears through as it goes up the stack