Implement map builtin function
#64
Open
+185
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
friendlymatthew
changed the title
map builtin function
Member
samuelcolvin
left a comment
samuelcolvin
left a comment
There was a problem hiding this comment.
also needs tests for more error cases
Comment on lines
+32
to
+35
| for (k, v) in kwargs { | ||
| k.drop_with_heap(heap); | ||
| v.drop_with_heap(heap); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| for (k, v) in kwargs { | |
| k.drop_with_heap(heap); | |
| v.drop_with_heap(heap); | |
| } | |
| kwargs.drop_with_heap(heap); |
or something
Member
Author
There was a problem hiding this comment.
nice. we can do the same in zip, sorted, min_max, etc
Comment on lines
+36
to
+38
| for v in positional { | ||
| v.drop_with_heap(heap); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| for v in positional { | |
| v.drop_with_heap(heap); | |
| } | |
| positional.drop_with_heap(heap); |
also positional should probably be called args.
Member
Author
There was a problem hiding this comment.
This PR should help clean up how we drop items: #69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
map()builtin function that applies a function to items from one or more iterables, returning a list of results.Note: it stops at the shortest iterable when multiple are provided. Currently, it only supports builtin functions and the
strict=parameter is not yet supported