Add support for non-string enums in Gemini #1564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might need a bit of assistance with setting up tests. Not too familiar with pytest and how it's used in this codebase. Or if someone is willing, there's an example in the linked issue that can be used as a test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1553.
Gemini requires that enums must consist of only string members (e.g. currently
IntEnumwill cause a failure.). This PR modifies the_GeminiJsonSchemato reflect this, whilst still making it such that theoutput_typeremains the correct type (e.g.IntEnum).For an example, please reference the linked issue.