Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Install playwright for all of our tests #2133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trallard
Copy link
Collaborator

Ensures playwright is always available for tests following conversations in #2119 (comment)

Note, however, that the test_version_switcher_highlighting test is currently failing due to changes to the version switcher component (as part of recent a11y improvements) and due to RTD version switcher no longer being flushed into the sidebar (#2034).

I could try and add an alternative test that checks perhaps that we have at least a latest and a dev version in the version switcher?

@trallard trallard added the tag: testing Issues related to PST testing label Feb 17, 2025
@peytondmurray
Copy link
Contributor

Tested this locally with tox run -ve compile-assets,i18n-compile,py312-sphinx61-tests. Looks like it did run the playwright tests 👍

Local testing replicated only one of these failures - the version switcher - could this be a test that should have been failing before (but wasn't, because it wasn't being run)?

FAILED tests/test_playwright.py::test_version_switcher_highlighting[chromium] - playwright._impl._errors.TimeoutError: Locator.get_attribute: Timeout 30000ms exceeded.

@trallard
Copy link
Collaborator Author

Definitely, that is the same test that I saw failing. Since that test was added the version switcher has changed a bit so nobody noticed this failing until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: testing Issues related to PST testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants