-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Vector2.from_polar and Vector3.from_spherical classmethods #2141
Draft
oddbookworm
wants to merge
13
commits into
pygame-community:main
Choose a base branch
from
oddbookworm:Vector2.from_polar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3a3e853
added Vector2.from_polar and Vector3.from_spherical classmethods
oddbookworm 1ec3582
cleaned up stub info for Vector2.from_polar and Vector3.from_spherical
oddbookworm 35e8705
removed unnecessary import
oddbookworm f7da8bf
Merge branch 'main' into Vector2.from_polar
MyreMylar f4586b7
Add coauthor
MyreMylar 4607c1a
Try ignoring mypy error
MyreMylar 313b005
Merge branch 'main' of https://github.com/pygame-community/pygame-ce …
oddbookworm dab637f
removed call to _PyArg_NoKeywords
oddbookworm 10e8f58
fixed fixed PyErr_SetString call
oddbookworm b7b723d
Merge branch 'main' of https://github.com/pygame-community/pygame-ce …
oddbookworm c0e8617
Merge branch 'main' of https://github.com/pygame-community/pygame-ce …
oddbookworm 58ceaa7
Made from_polar and from_spherical fastcall
oddbookworm 69743f2
Fix some grammar
oddbookworm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the hack for typing fails for the class call. A bit of experimentation gives a different fix, in mypy.
This should also be applied to
from_spherical
.P.S.: The new
Point
andSequenceLike
types should be integrated into the PR if it is going to be merged.