Added missing Circle attrs #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzpr3d4t0r
added
New API
|
Looks like this needs stubs! |
Oh god yeah forgot the stubs xD. |
MyreMylar
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
I think we should add 'radius' as an alias for 'r' just as we have 'diameter' and 'd' - for consistency.
Otherwise it all works well and makes the draw.circle use case simpler:
circle_1 = Circle((50, 50), 30)
...
pygame.draw.circle(screen, Color("red"), circle_1.center, circle_1.r)
Approved 👍
|
Hmm, this PR seems to have conflicts now |
ankith26
reviewed
Nov 2, 2023
ankith26
reviewed
Nov 2, 2023
|
I'll squash and merge but add the co-authors you mentioned in the last section of the PR comment. Thanks to all who contributed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #2267. This PR adds the following attributes to the
Circleclass:r_sqr: representing the radius squaredcenter: a tuple containing the x and yd,diameterareacircumferenceIt also adds a new internal C api function for creating tuples more efficiently:
pg_tuple_couple_from_values_double.Credits
Geometry Project:
For code, docs and tests:
@novialriptide @Emc2356 @itzpr3d4t0r @ScriptLineStudios @avaxar @Matiiss @newpaxonian @maqa41 @blankRiot96
Also thanks to @Starbuck5 for kickstarting the idea and the occasional help!
Functionality added in this PR
circle.chttps://github.com/pygame-community/pygame-geometry/blame/main/src_c/circle.c
Credits to @Emc2356 @itzpr3d4t0r @novialriptide
geometry_test.pyhttps://github.com/pygame-community/pygame-geometry/blame/main/test/test_circle.py
Credits to @itzpr3d4t0r @novialriptide
geometry.rsthttps://github.com/pygame-community/pygame-geometry/blame/main/docs/circle.rst
Credits to @itzpr3d4t0r