-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pkgdata rework #2552
base: main
Are you sure you want to change the base?
Pkgdata rework #2552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just some small concerns about reference counting versus the code being replaced.
f4ba2e0
to
794d7e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... There is a common pattern of importing the module in C code and calling the function. Maybe it could be better abstracted away in a common function?
getResource()
Reasons:
pkg_resources
lib is out dated.get_resource_path()
Get the pygame resource path by its filename
Example:
load_pygame_icon()
Load the default pygame icon
load_pygame_icon()
andget_resource_path()