-
-
Notifications
You must be signed in to change notification settings - Fork 193
Add outline option for rendering fonts #2828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
narilee2006
wants to merge
11
commits into
pygame-community:main
Choose a base branch
from
narilee2006:outlineee
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+289
−64
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6fbcb1a
rm
narilee2006 3b15e7d
Add outline & docs
narilee2006 bdb70ed
Add testing
narilee2006 fca9305
Remove README.md
narilee2006 a975224
Fix some bugs
narilee2006 edcb35f
Adjust code to Andrew Coffeey's reviews.
narilee2006 0a617b9
Re-implement outline with color and size properties.
narilee2006 fc29c93
Move font rendering implementation into a separate method
narilee2006 cd2142a
Modify surface through reference
narilee2006 52c51ba
Creates a filled and outlined font
narilee2006 c7bf3e2
Adjust code to reviews from Robert Pfeiffer and Charlie Hayden
narilee2006 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -306,6 +306,30 @@ solves no longer exists, it will likely be removed in the future. | |
|
||
.. ## Font.point_size ## | ||
|
||
.. attribute:: outline_width | ||
|
||
| :sl:`Gets or sets the font's outline radius size` | ||
| :sg:`outline_width -> int` | ||
|
||
Gets or sets the radius size of the outline in pixels defaulting to 0. | ||
|
||
If the value is set to 0, it shows no outline. | ||
|
||
.. versionadded:: 2.5.0 | ||
|
||
.. ## Font.outline_width ## | ||
|
||
.. attribute:: outline_color | ||
|
||
| :sl:`Gets or sets the font's outline color` | ||
| :sg:`outline_width -> RGB` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You say (0, 0, 0, 255), but that's RGBA. |
||
|
||
Gets or sets the color of the outline defaulting to (0, 0, 0, 255) | ||
|
||
.. versionadded:: 2.5.0 | ||
|
||
.. ## Font.outline_color ## | ||
|
||
.. method:: render | ||
|
||
| :sl:`draw text on a new Surface` | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outline_radius
is a better name if you're already going to mention radius in the docs description.