Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move transform towards compiling w/ SDL3 #3314

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Move transform towards compiling w/ SDL3 #3314

merged 1 commit into from
Feb 18, 2025

Conversation

Starbuck5
Copy link
Member

#3310 but for transform.

@Starbuck5 Starbuck5 added transform pygame.transform sdl3 labels Jan 27, 2025
@Starbuck5 Starbuck5 requested a review from a team as a code owner January 27, 2025 07:37
@Starbuck5 Starbuck5 marked this pull request as draft January 27, 2025 07:37
@Starbuck5 Starbuck5 changed the title Move Surface towards compiling w/ SDL3 Move transform towards compiling w/ SDL3 Jan 27, 2025
Starbuck5
Starbuck5 commented Jan 27, 2025
View reviewed changes
@Starbuck5 Starbuck5 force-pushed the transform-sdl3-a-bit branch from 5812d7e to 4e24774 Compare January 27, 2025 07:47
@Starbuck5 Starbuck5 marked this pull request as ready for review January 28, 2025 07:21
@Starbuck5 Starbuck5 force-pushed the transform-sdl3-a-bit branch from 4e24774 to 52967d0 Compare February 2, 2025 09:14
@Starbuck5
Copy link
Member Author

Rebased so it uses latest SDL2/SDL3 updates. (has it on the branch, so you don't need to swap dep versions between main and this).

ankith26
ankith26 approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

damusss
damusss approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some good progress, thanks! 💯

@damusss damusss added this to the 2.5.4 milestone Feb 18, 2025
@damusss damusss merged commit 717d6d0 into pygame-community:main Feb 18, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
sdl3 transform pygame.transform
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @ankith26 @damusss