Skip to content

Move modules to their own directories #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 94 commits into
base: main
Choose a base branch
from

Conversation

MightyJosip
Copy link
Member

Big pygame refactor

@MightyJosip MightyJosip requested a review from a team as a code owner April 29, 2025 18:02
@Starbuck5
Copy link
Member

Hey MightyJosip, this is a very interesting branch to navigate around to navigate the concept. It's a very cool concept, I'm still in support.

Things I notice navigating around:
I noticed that while colordict is technically a private dep of the color module and goes in the color folder, pypm/surflock/constants/locals are put as separate modules from their public facing brethren.

I feel like more grouping is a better, like what you have as _debug, base, constants, locals, macosx, pkgdata, pygame, and rwobject could all be one grouping. Pypm should definitely go part of midi.

I'm not sure a good place for static and resources, you've put them here like they're modules, which is a little strange but I don't have a better suggestion right now.


I don't believe we can or should do this as one huge PR, rather an incremental effort with smaller PRs.

@MightyJosip
Copy link
Member Author

Hi, thanks for comment. Yea this is more like proof of concept, we can still discuss it in more details, and split the commit.

Just one question, what is your opinion about X_test.py files, should they be moved together with the code as well, or it should be in the specific folder (so we would have src/ and test/ split up, just like now). In this commit it is together, but I can split it again

@damusss
Copy link
Member

damusss commented Apr 30, 2025

Just one question, what is your opinion about X_test.py files, should they be moved together with the code as well, or it should be in the specific folder (so we would have src/ and test/ split up, just like now). In this commit it is together, but I can split it again

I actually think that putting them in the respective folder is better, that way if you make a change to some particular thing you have all the files you may want to modify in the same place. it makes sense, it's practical. And I agree with 'buck about grouping more private/internal modules like base or locals. Apart from that I really like the idea too, it's very clean IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants