Skip to content

Conversation

ankith26
Copy link
Member

  • blend got removed in 2.4.0
  • blend was re-added in 2.5.0 as a no-op
  • added a width implementation in 2.5.2 but reverted it for that release only when it should have also been reverted for all upcoming releases.
  • 2.5.3, 2.5.4 and 2.5.5 all use the initial width implementation. The problem here is that the width argument is coming in place of the depth argument so we are still breaking compat.
  • just got the new width implementation in for 2.5.6.dev1. Still have the same issue as the previous three releases.

I saw 2 potential fixes for this situation:
fix 1: make width keyword only, put it after the blend arg, announce the API as new in 2.5.6 and pretend nothing happened in 2.5.[3-5]
fix 2: roll with whatever we have right now. This somehow works out because old code doing blend=1 or blend=True would now mean width=1 which is equivalent. We just need to add compat code that handles width <= 0 like width=1. We can then advertise that the "width argument replaces the blend argument" and old code doesn't break too bad.

@ankith26 ankith26 requested a review from a team as a code owner June 18, 2025 07:50
@ankith26 ankith26 added this to the 2.5.6 milestone Jun 18, 2025
@ankith26 ankith26 force-pushed the ankith26-fix-aaline branch from 8b8fa3d to d408e1d Compare June 18, 2025 09:22
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the small internal API change makes sense to me. Should handle old code successfully without encouraging it and move us more smoothly into the new era of wider aalines.

It runs fine locally as well. Approved.

@MyreMylar MyreMylar merged commit 5541963 into main Aug 25, 2025
26 checks passed
@ankith26 ankith26 deleted the ankith26-fix-aaline branch August 25, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants