Skip to content

Fix keyerror in querying capabilities (reported for AMD hardware) #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almarklein merged 4 commits into from
Dec 17, 2025
Merged

Fix keyerror in querying capabilities (reported for AMD hardware) #785

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85486c7
Use .get when mapping with enum_int2str
almarklein Dec 17, 2025
9903f84
Merge branch 'main' into safe-enum_int2str
almarklein Dec 17, 2025
867f5ad
None is not needed
almarklein Dec 17, 2025
f2ada53
Merge branch 'safe-enum_int2str' of github.com:pygfx/wgpu-py into saf…
almarklein Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions wgpu/backends/wgpu_native/_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,9 @@ def _get_capabilities_screen(self, adapter):
capabilities["formats"] = formats = []
Copy link
Contributor

@Vipitis Vipitis Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a side note on this syntax... the list mutability gets exploited here like a pointer. formats isn't used below this anymore... yet it still works.

I found this sorta confusing in python.

Copy link
Collaborator

@Korijn Korijn Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is pass by reference in python. It would be weird if capabilities["formats"] and formats were independent copies though right?

capabilities["formats"] = formats = [] is not short for:

capabilities["formats"] = []
formats = []

It's short for:

formats = []
capabilities["formats"] = formats

That's how I think about it at least.

Copy link
Member Author

@almarklein almarklein Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case the formats is indeed a temporary variable, to avoid the repetitive dict lookup for doing capabilities["formats"].append(str_val).

for i in range(c_capabilities.formatCount):
int_val = c_capabilities.formats[i]
formats.append(enum_int2str["TextureFormat"][int_val])
str_val = enum_int2str["TextureFormat"].get(int_val)
if str_val:
formats.append(str_val)

else:
capabilities["formats"] = minimal_capabilities["formats"]
Expand All @@ -779,17 +781,19 @@ def _get_capabilities_screen(self, adapter):
capabilities["alpha_modes"] = alpha_modes = []
for i in range(c_capabilities.alphaModeCount):
int_val = c_capabilities.alphaModes[i]
str_val = enum_int2str["CompositeAlphaMode"][int_val]
alpha_modes.append(str_val.lower())
str_val = enum_int2str["CompositeAlphaMode"].get(int_val)
if str_val:
alpha_modes.append(str_val.lower())
else:
capabilities["alpha_modes"] = minimal_capabilities["alpha_modes"]

if c_capabilities.presentModes:
capabilities["present_modes"] = present_modes = []
for i in range(c_capabilities.presentModeCount):
int_val = c_capabilities.presentModes[i]
str_val = enum_int2str["PresentMode"][int_val]
present_modes.append(str_val.lower())
str_val = enum_int2str["PresentMode"].get(int_val)
if str_val:
present_modes.append(str_val.lower())
else:
capabilities["present_modes"] = minimal_capabilities["present_modes"]

Expand Down