Open
Conversation
Contributor
Author
|
Think there's still some good changes here worth including, so just creating a PR with the remaining changes I had. Will also push my partial typing of tests up later as a separate PR, if it looks like we can work around the awkward nested classes. |
Contributor
|
I recommend keeping 'if TYPE_CHECKING' as it reduces chances for circular imports and does not import unneeded modules at runtime. |
Contributor
Author
|
Yeah, I don't mind too much. I usually find it preferable to have real imports where possible. |
Contributor
Author
|
Kept one where the module was already imported for another object, have reverted the rest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.