Decompose Tridiagonal Solve into core steps #1382
Draft
+785
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
decompose_tridiagonal_solve
branch
from
cc4fab6 to
c72326e
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ricardoV94
force-pushed
the
decompose_tridiagonal_solve
branch
2 times, most recently
from
c9caeca to
df0ec58
Compare
ricardoV94
force-pushed
the
decompose_tridiagonal_solve
branch
from
df0ec58 to
2436cd1
Compare
ricardoV94
force-pushed
the
decompose_tridiagonal_solve
branch
from
2436cd1 to
aceab09
Compare
ricardoV94
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1396, extending it to the tridiagonal case.
It also adds a rewrite for when extracting diagonals out a symbolically allocated diagonal matrix (via set_subtensor or AllocDiag after it gets inlined during specialization)
TODO: