-
Notifications
You must be signed in to change notification settings - Fork 77
Enable multiple treated units in synthetic control quasi experiments #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
59c5b6e
initial commit - utilising vibe coding
drbenvincent 26691ec
update multi cell geolift notebook with new functionality/API
drbenvincent 4fa1650
add test that the r2 scores differ across treated units
drbenvincent 7b473af
simplify plot code
drbenvincent be01357
revert to simpler plot titles
drbenvincent 47e0a2d
rename primary_unit_name -> treated_unit + revert to no "Unit" title
drbenvincent ee8a92b
revert change in causal impact shaded region colour
drbenvincent b79743f
code simplifications by always having a treated_units dimension
drbenvincent aa9920a
code simplification relating to _get_score_title
drbenvincent ebddbb5
another code simplification - related to scoring
drbenvincent eac1ef3
code simplification in _ols_plot
drbenvincent 1a5f9bd
code simplification related to PyMCModel._data_setter
drbenvincent e67a28c
add sphinx-togglebutton for a collapsible admonition + other updates …
drbenvincent d0fc0d3
update uml diagrams
drbenvincent b6f5ca8
PyMCModel.score always to get xr.DataArray arguments
drbenvincent 8badc05
simplification to PyMC.print_coefficients
drbenvincent 4a78a50
simplification of WeightedSumFitter.build_model
drbenvincent f1849b1
clean up PyMCModel.predict + PyMCModel._data_setter
drbenvincent a55f97d
remove a numerical index in favour of a named dimension
drbenvincent 6341e53
make code comment more specific
drbenvincent 2befccb
consolidate tests, fix doctest
drbenvincent 78be544
Merge branch 'main' into multi-cell-geolift
drbenvincent 37e8de7
set fixture scope to module
drbenvincent d0c520f
towards a more unified scoring (r2) approach
drbenvincent 3ee430e
more unification with score (r2) in terms of unified naming: unit_{n}_r2
drbenvincent adf04f9
refactor PyMCModel.score
drbenvincent 25608ef
the grand simplification
drbenvincent 2fba338
tweak docstring
drbenvincent 4e63dfa
Merge branch 'main' into multi-cell-geolift
drbenvincent 04ace83
update class diagram
drbenvincent 192327d
re-run relevant notebooks
drbenvincent 8579a14
less confusing variable names
drbenvincent 3101cdc
improve type hints
drbenvincent b213b0f
combined=True in az.plot_forest in brexit synthetic control example
drbenvincent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.