Skip to content

test: fixes for pymmcore v11.5#451

Merged
tlambert03 merged 4 commits into
pymmcore-plus:mainfrom
tlambert03:fix-tests
Mar 25, 2025
Merged

test: fixes for pymmcore v11.5#451
tlambert03 merged 4 commits into
pymmcore-plus:mainfrom
tlambert03:fix-tests

Conversation

@tlambert03

Copy link
Copy Markdown
Member

the new version of pymmcore changes a few things that break tests. This fixes it. see also micro-manager/pymmcore#131

@codecov

codecov Bot commented Mar 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (e7a6153) to head (f050737).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_plus/model/_config_file.py 58.33% 5 Missing ⚠️
src/pymmcore_plus/metadata/functions.py 50.00% 3 Missing ⚠️
src/pymmcore_plus/model/_pixel_size_config.py 66.66% 3 Missing ⚠️
src/pymmcore_plus/core/_mmcore_plus.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   91.51%   91.09%   -0.42%     
==========================================
  Files          62       62              
  Lines        5277     5322      +45     
==========================================
+ Hits         4829     4848      +19     
- Misses        448      474      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Mar 25, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #451 will not alter performance

Comparing tlambert03:fix-tests (f050737) with main (0b7a74a)

Summary

✅ 7 untouched benchmarks

@tlambert03

Copy link
Copy Markdown
Member Author

the only failing tests now needs to be fixed on the pymmcore-widgets side: pymmcore-plus/pymmcore-widgets#414

@tlambert03 tlambert03 merged commit 54dabb5 into pymmcore-plus:main Mar 25, 2025
@tlambert03 tlambert03 deleted the fix-tests branch March 25, 2025 14:16
@tlambert03 tlambert03 added the tests tests & CI label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests tests & CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant