Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix stage widget #414

Merged
merged 2 commits into from
Mar 25, 2025
Merged

test: fix stage widget #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e11af
tests: fix stage widget
tlambert03 Mar 25, 2025
82766ca
fix useq widget
tlambert03 Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions tests/test_stage_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

from typing import TYPE_CHECKING

from pymmcore_plus import DeviceType

from pymmcore_widgets.control._stage_widget import StageWidget

if TYPE_CHECKING:
Expand All @@ -12,6 +14,8 @@
def test_stage_widget(qtbot: QtBot, global_mmcore: CMMCorePlus) -> None:
# test XY stage
stage_xy = StageWidget("XY", levels=3, absolute_positioning=True)
stage_xy._poll_cb.setChecked(True)
stage_xy.show()
qtbot.addWidget(stage_xy)

assert global_mmcore.getXYStageDevice() == "XY"
Expand All @@ -35,43 +39,44 @@ def test_stage_widget(qtbot: QtBot, global_mmcore: CMMCorePlus) -> None:

xy_up_3 = stage_xy._move_btns.layout().itemAtPosition(0, 3)
xy_up_3.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert (
(y_pos + (stage_xy.step() * 3)) - 1
< global_mmcore.getYPosition()
< (y_pos + (stage_xy.step() * 3)) + 1
)
assert stage_xy._x_pos.value() == 0
assert stage_xy._y_pos.value() == 15
qtbot.waitUntil(lambda: stage_xy._y_pos.value() == 15)

xy_left_1 = stage_xy._move_btns.layout().itemAtPosition(3, 2)
global_mmcore.waitForDevice("XY")
xy_left_1.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert (
(x_pos - stage_xy.step()) - 1
< global_mmcore.getXPosition()
< (x_pos - stage_xy.step()) + 1
)
assert stage_xy._x_pos.value() == -5
qtbot.waitUntil(lambda: stage_xy._x_pos.value() == -5)
assert stage_xy._y_pos.value() == 15

global_mmcore.waitForDevice("XY")
stage_xy._x_pos.setValue(5)
stage_xy._x_pos.editingFinished.emit()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert 4 < global_mmcore.getXPosition() < 6

global_mmcore.waitForDevice("XY")
stage_xy._y_pos.setValue(5)
stage_xy._y_pos.editingFinished.emit()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert 4 < global_mmcore.getYPosition() < 6

global_mmcore.waitForDevice("XY")
global_mmcore.setXYPosition(0.0, 0.0)
assert stage_xy._x_pos.value() == 0
assert stage_xy._y_pos.value() == 0
global_mmcore.waitForDeviceType(DeviceType.XYStage)
qtbot.waitUntil(lambda: stage_xy._x_pos.value() == 0)
qtbot.waitUntil(lambda: stage_xy._y_pos.value() == 0)

stage_xy.snap_checkbox.setChecked(True)
with qtbot.waitSignal(global_mmcore.events.imageSnapped):
global_mmcore.waitForDevice("XY")
global_mmcore.waitForDeviceType(DeviceType.XYStage)
xy_up_3.widget().click()
with qtbot.waitSignal(global_mmcore.events.imageSnapped):
stage_xy._x_pos.setValue(10)
Expand Down Expand Up @@ -202,18 +207,27 @@ def test_invert_axis(qtbot: QtBot, global_mmcore: CMMCorePlus) -> None:
stage_xy.setStep(15.0)

xy_left_1.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert global_mmcore.getXPosition() == -15.0
xy_left_1.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert global_mmcore.getXPosition() == -30.0
global_mmcore.waitForSystem()
stage_xy._invert_x.setChecked(True)
xy_left_1.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
xy_left_1.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert global_mmcore.getXPosition() == 0.0

global_mmcore.waitForSystem()
xy_up_3.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert global_mmcore.getYPosition() == 45.0
global_mmcore.waitForSystem()
stage_xy._invert_y.setChecked(True)
xy_up_3.widget().click()
global_mmcore.waitForDeviceType(DeviceType.XYStage)
assert global_mmcore.getYPosition() == 0.0

stage_z = StageWidget("Z", levels=3)
Expand Down
3 changes: 3 additions & 0 deletions tests/test_useq_core_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,12 @@ def test_core_connected_position_wdg(qtbot: QtBot, qapp) -> None:

wdg._mmc.setXYPosition(11, 22)
wdg._mmc.setZPosition(33)
wdg._mmc.waitForSystem()
xyidx = pos_table.table().indexOf(pos_table._xy_btn_col)
z_idx = pos_table.table().indexOf(pos_table._z_btn_col)
pos_table.table().cellWidget(0, xyidx).click()
pos_table.table().cellWidget(0, z_idx).click()

p0 = pos_table.value()[0]
assert round(p0.x) == 11
assert round(p0.y) == 22
Expand Down Expand Up @@ -554,6 +556,7 @@ def test_mda_no_pos_set(global_mmcore: CMMCorePlus, qtbot: QtBot):

MDA = useq.MDASequence(channels=[{"config": "DAPI", "exposure": 1}])
wdg.setValue(MDA)
wdg._mmc.waitForSystem()

assert wdg.value().stage_positions
assert round(wdg.value().stage_positions[0].x) == 10
Expand Down