-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin pypa/build
, pyodide-lock
, and pytest
for testing requirements
#197
Unpin pypa/build
, pyodide-lock
, and pytest
for testing requirements
#197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for the review! |
I'm a bit uncomfortable about the idea that we might release pyodide-lock and only then discover that we broke micropip. But perhaps there isn't much api surface. |
I agree, @hoodmane – though my idea was that keeping We could add a CI job to test with nightly versions of the test dependencies, but that could also be overkill. |
Yeah it just feels worse when we break ourselves. But I agree in practice it's the same. I'm sure the build 0.7.0 pin was accidentally inherited from the pyodide-build pin on build which used to access a very large number of build implementation details. |
Description
This pull request unpins:
pypa/build
, as we were using a very old version, and we were not the same version as whatpyodide-build
uses;build==1.2.2post1
APIpyodide-lock
, so that we can be aware when something upstream inpyodide-lock
changes/fails here; andpytest
, as v8 is reasonably stable now, and the latest version is 8.3.4 at the time of writing.