Don't raise HTTPStatusError on CORS errors when querying packages in a transaction
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanking13, is this what you had in mind? |
ryanking13
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
@ryanking13, is this what you had in mind?
Yes, exactly. I think you can remove HttpStatusError from the compatibility code as it is not imported anymore.
Co-authored-by: Gyeongjae Choi <[email protected]>
for more information, see https://pre-commit.ci
|
Okay, done! I have to say this is a part of |
ryanking13
approved these changes
Mar 28, 2025
| @@ -13,14 +13,6 @@ class CompatibilityLayer(ABC): | |||
| All of the following methods / properties must be implemented for use both inside and outside of pyodide. | |||
| """ | |||
|
|
|||
| class HttpStatusError(ABC, Exception): | |||
There was a problem hiding this comment.
Done in abc1437; I didn't realise you were asking to remove HttpStatusErrors completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #223; this PR changes the behaviour to not stop at CORS errors when querying an index. This should serve as a temporary respite when installing from indices that don't add CORS headers for 404s and the like, such as Anaconda.org.