install: Allow setting extras explicitly #253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes-To: pyodide#205 (comment)
|
Thanks for the draft implementation. Do you think supporting |
|
Closing in favor of #254, which seems to be on a good track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot at #205.
Frankly, I'm not super happy with it -- it's threading the extras quite wide through it, and it has the unsightly constraint that it only really works well with a single requirement (for it'd be quite unlikely that the same extras make sense for multiple requirements). I'll leave it here mainly as a discussion tool to find out whether #205 (comment) is really pointing in a good direction (and to see what CI has to say, for I have no clue how I'd test this a full pyodide around it).