Skip to content

Apply PIP_CONSTRAINT correctly #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hoodmane wants to merge 1 commit into from
Closed

Apply PIP_CONSTRAINT correctly #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyodide_build/pypabuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ def _build_in_isolated_env(

# first install the build dependencies
symlink_unisolated_packages(env)
os.environ["PIP_CONSTRAINT"] = build_env["PIP_CONSTRAINT"]

@ryanking13 ryanking13 Nov 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment that this is only for in-tree build for future readers.

For OOT build, a user needs to set PIP_CONSTRAINT if needed.

install_reqs(env, builder.build_system_requires)
installed_requires_for_build = False
try:
Expand Down