Add more detail on platform mismatch errors#13988
Open
sepehr-rs wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5003
When pip can't find a matching distribution, it now shows why each available distribution was rejected. This replaces the old unhelpful message "No matching distribution found for X" with a summary of skipped candidates, grouped by rejection reason.
Example:
One limitation is that printing every rejected candidate makes the output grow very quickly (over 3,000 lines in the example above), and this caused several tests to fail. Because of that, verbose mode currently shows the same summarized output instead of listing every rejected candidate individually.
I’d welcome any feedback on whether this trade‑off seems reasonable, and whether it would be useful to expose the full list of rejected candidates in some other way (for example behind a separate flag or with additional safeguards).