Refactor: Memoize editable_project_location#14144
Open
lets-build-an-ocean wants to merge 1 commit into
Open
Conversation
Use functools.cached_property instead of property to avoid recomputing this on every access, as noted in the TODO.
Contributor
Author
|
I am not sure if we need NEWS update for this PR or no. lemme know ! |
sepehr-rs
added
the
skip news
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
editable_project_locationfrom@propertyto@functools.cached_propertyto avoid recomputing it on every access, resolving the TODO in the code.