Revert a large part of the wheel removal, to support Python 3.8 #2876
+65
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
reviewed
Apr 29, 2025
5 tasks
gaborbernat
reviewed
Apr 29, 2025
…to be installed, but it isn't" This reverts commit c93d2a6.
stefanor
changed the title
stefanor
force-pushed
the
virtualenv-not-pip
branch
2 times, most recently
from
30b777d to
939e40f
Compare
Pip 25.1 (which understands that wheel is not needed) is not supported on Python 3.8, so we continue to ship pip 25.0.1 for Python 3.8, and provide wheel. This is a partial revert of commit db1d9fc. Once support for Python 3.8 has been removed, this can be reverted.
stefanor
force-pushed
the
virtualenv-not-pip
branch
from
939e40f to
0e93c52
Compare
gaborbernat
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a cleanup to a whoopsie in #2868 (thanks @hroncok).
Revert many parts of our wheel removal to support Python 3.8. Pip 25.1 (which understands that wheel is not needed) is not supported on Python 3.8, so we continue to ship pip 25.0.1 for Python 3.8, and provide wheel.
This contains a partial revert of commit db1d9fc. Once support for Python 3.8 has been removed, it can be reverted again.