Skip to content

fix: check if key exists in attributes before accessing the dict #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: check if key exists in attributes before accessing the dict #101

wants to merge 1 commit into from

Conversation

@peterhoneder
Copy link

@peterhoneder peterhoneder commented Oct 26, 2018

otherwise a KeyError would be thrown in line 415 of the original packet.py

@peterhoneder peterhoneder mentioned this pull request Oct 26, 2018
Open
@twschum
Copy link

twschum commented Apr 8, 2019

This relates to #87 and also only fixes one instance of the above issue without adding tests. See #107 for a more complete fix to the same issue :)

@GIC-de GIC-de force-pushed the master branch 2 times, most recently from f028133 to 5300091 Compare July 13, 2022 12:23
@GIC-de
Copy link
Collaborator

GIC-de commented Jul 24, 2024

If this issue is still relevant, please rebase and resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterhoneder @twschum @GIC-de