Skip to content

Conversation

@Pat-pGuo
Copy link

Extends work from #205

For review:

  • Adds nesting to dictionary attributes and packet values
    • sub-attributes are stored as children of their parent attributes
    • sub-attributes are not visible in the global namespace, only their parents
    • vendor attributes are children of vendors, which are children of the Vendor-Specific attribute

@Pat-pGuo Pat-pGuo force-pushed the feature/allow-nested-attributes branch from f13d92d to f4bc7b7 Compare December 11, 2024 20:31
@Pat-pGuo Pat-pGuo marked this pull request as ready for review December 11, 2024 20:31
@nicholasamorim
Copy link

nicholasamorim commented Jul 10, 2025

I have a question about this PR. In the dictionary, @Pat-pGuo. There is this code:

self.attributes = {}
self.defer_parse = []

self.stack = AttrStack()
# the global attribute namespace is the first layer
self.stack.push(self.attributes, self.attrindex)

The code does seem to work, however, the signature for push specifies that the first argument to push is an Attribute instance and not a dict as passed. What would be the correct fix here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants