send 224x224 detection crop alongside full frame#359
Open
MateoLostanlen wants to merge 2 commits intodevelopfrom
Open
send 224x224 detection crop alongside full frame#359MateoLostanlen wants to merge 2 commits intodevelopfrom
MateoLostanlen wants to merge 2 commits intodevelopfrom
Conversation
Crops the original (pre-resize) frame around the detection bboxes, expands the longest side by 20%, squares it, clamps inside image borders, then resizes to 224x224 with JPEG q=95 when downscaling and q=100 (subsampling=0, optimize=True) when the crop was already at or below 224. The crop is forwarded to pyroclient.create_detection as a new `crop` kwarg — requires the matching pyroclient + API change to accept the second media file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyroclient.create_detectionvia a newcrop=kwarg.Depends on
pyroclientchange: feat(detections): accept optional crop image for faster smoke checks pyro-api#575Until that PR is merged and the lockfile is bumped, alert uploads will raise
TypeError— do not merge in isolation.