fix: support mixed bool and float in maxp#519
Open
samay2504 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes MaxPHeuristic failing when attrs_name contains mixed bool + numeric columns by ensuring the attribute matrix passed into SciPy distance computation is always numeric, and adds a regression test for the reported scenario (issue #498).
Changes:
- Cast
gdf[attrs_name]to afloatNumPy array prior topdistto avoidobject-dtype failures when boolean columns are included. - Add a regression test that constructs a mixed bool+float attribute set and asserts
solve()returns labels for all observations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spopt/region/maxp.py |
Normalizes covariate inputs to a numeric (float) array before computing distances. |
spopt/tests/test_region/test_maxp.py |
Adds regression coverage for mixed boolean + float covariates in MaxPHeuristic.solve(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=====================================
Coverage 76.9% 76.9%
=====================================
Files 29 29
Lines 3700 3700
=====================================
Hits 2846 2846
Misses 854 854
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #498 by normalising MaxP covariate input to a numeric array before distance computation, which allows mixed
boolandfloatcolumns to be used safely without triggering SciPy object-dtype errors, and it adds a regression test that builds a mixed bool+float attribute set and verifiesMaxPHeuristic.solve()completes and returns labels for all observations.