Enable qInfo tests for PySide6 #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PySide6 now exposes `qInfo` just like Qt6. This enables the `qInfo` tests accordingly. For reference see issue pytest-dev#232.
|
Some additional info: I noticed |
nicoddemus
approved these changes
Mar 11, 2025
The-Compiler
added a commit
that referenced
this pull request
Mar 25, 2025
The-Compiler
added a commit
that referenced
this pull request
Mar 25, 2025
qInfo() has been added: https://codereview.qt-project.org/c/pyside/pyside-setup/+/605100 Follow-up / alternative to #593 without breaking compatibility with older PySide6 versions. See #232.
The-Compiler
added a commit
that referenced
this pull request
Mar 25, 2025
qInfo() has been added: https://codereview.qt-project.org/c/pyside/pyside-setup/+/605100 Follow-up / alternative to #593 without breaking compatibility with older PySide6 versions. See #232.
|
This breaks compatibility with PySide6 < 6.8.2. Reverted and pushed an alternative fix in #597. |
The-Compiler
added a commit
that referenced
this pull request
Mar 25, 2025
The-Compiler
added a commit
that referenced
this pull request
Mar 25, 2025
qInfo() has been added: https://codereview.qt-project.org/c/pyside/pyside-setup/+/605100 Follow-up / alternative to #593 without breaking compatibility with older PySide6 versions. See #232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PySide6 now exposes
qInfojust like Qt6. This enables theqInfotests accordingly.
For reference see issue #232.