Handle --version eagerly to avoid loading the entire infrastructure #13575
+52
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
commented
Jun 28, 2025
| config = pytester.parseconfig("--config-file", "custom.toml") | ||
| assert config.getini("custom") == "1" | ||
|
|
||
| def test_absolute_win32_path(self, pytester: Pytester) -> None: |
There was a problem hiding this comment.
I tracked this test to this changelog entry:
* Fix win32 path issue when puttinging custom config file with absolute path
in ``pytest.main("-c your_absolute_path")``.
Seems --version being in the config file has nothing to do with the original issue.
nicoddemus
force-pushed
the
update-13480-changelog
branch
from
7bde507 to
cdd40ed
Compare
Currently, handling `--version` in `pytest_cmdline_main` requires loading the entire infrastructure, which can be slow depending on the installed plugins. This change introduces a marginal behavioral difference, though it should not cause any issues in practice. Fixes pytest-dev#13574
nicoddemus
force-pushed
the
update-13480-changelog
branch
from
cdd40ed to
1315e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, handling
--versioninpytest_cmdline_mainrequires loading the entire infrastructure, which can be slow depending on the installed plugins.This change introduces a marginal behavioral difference, though it should not cause any issues in practice.
Fixes #13574